From dffa7b48982d29fd830c54e9541483a26c90a21c Mon Sep 17 00:00:00 2001
From: Cyrille Nofficial <cynoffic@cyrilix.fr>
Date: Sun, 21 Aug 2022 22:46:51 +0200
Subject: [PATCH] wip

---
 pkg/steering/bbox.go                  |  4 +-
 pkg/steering/bbox_test.go             | 59 +++++++++++++++++++++++++--
 pkg/steering/test_data/bboxes-02.json |  6 +--
 3 files changed, 60 insertions(+), 9 deletions(-)

diff --git a/pkg/steering/bbox.go b/pkg/steering/bbox.go
index 29c44b6..d8efdff 100644
--- a/pkg/steering/bbox.go
+++ b/pkg/steering/bbox.go
@@ -4,8 +4,8 @@ import (
 	"image"
 )
 
-func GroupBBoxes(bboxes []*image.Rectangle) []*image.Rectangle {
-	resp := make([]*image.Rectangle, 0, len(bboxes))
+func GroupBBoxes(bboxes []image.Rectangle) []image.Rectangle {
+	resp := make([]image.Rectangle, 0, len(bboxes))
 	copy(bboxes, resp)
 	return resp
 }
diff --git a/pkg/steering/bbox_test.go b/pkg/steering/bbox_test.go
index 28c684b..e6ccea5 100644
--- a/pkg/steering/bbox_test.go
+++ b/pkg/steering/bbox_test.go
@@ -3,10 +3,10 @@ package steering
 import (
 	"encoding/json"
 	"fmt"
+	"go.uber.org/zap"
 	"gocv.io/x/gocv"
 	"image"
 	"image/color"
-	_ "image/jpeg"
 	"os"
 	"reflect"
 	"testing"
@@ -23,6 +23,51 @@ type BBox struct {
 	Confidence float32 `json:"confidence"`
 }
 
+var (
+	bboxes1 []image.Rectangle
+	bboxes2 []image.Rectangle
+	bboxes3 []image.Rectangle
+	bboxes4 []image.Rectangle
+)
+
+func init() {
+	img1, bb, err := load_data("01")
+	if err != nil {
+		zap.S().Panicf("unable to load data test: %w", err)
+	}
+	defer img1.Close()
+	bboxes1 = bboxesToRectangles(bb, img1.Cols(), img1.Rows())
+
+	img2, bb, err := load_data("02")
+	if err != nil {
+		zap.S().Panicf("unable to load data test: %w", err)
+	}
+	defer img2.Close()
+	bboxes2 = bboxesToRectangles(bb, img2.Cols(), img2.Rows())
+
+	img3, bb, err := load_data("03")
+	if err != nil {
+		zap.S().Panicf("unable to load data test: %w", err)
+	}
+	defer img3.Close()
+	bboxes3 = bboxesToRectangles(bb, img3.Cols(), img3.Rows())
+
+	img4, bb, err := load_data("04")
+	if err != nil {
+		zap.S().Panicf("unable to load data test: %w", err)
+	}
+	defer img4.Close()
+	bboxes4 = bboxesToRectangles(bb, img4.Cols(), img4.Rows())
+}
+
+func bboxesToRectangles(bboxes []BBox, imgWidth, imgHeiht int) []image.Rectangle {
+	rects := make([]image.Rectangle, 0, len(bboxes))
+	for _, bb := range bboxes {
+		rects = append(rects, bb.toRect(imgWidth, imgHeiht))
+	}
+	return rects
+}
+
 func (bb *BBox) toRect(imgWidth, imgHeight int) image.Rectangle {
 	return image.Rect(
 		int(bb.Left*float32(imgWidth)),
@@ -144,14 +189,20 @@ func TestDisplayBBox(t *testing.T) {
 
 func TestGroupBBoxes(t *testing.T) {
 	type args struct {
-		bboxes []*image.Rectangle
+		bboxes []image.Rectangle
 	}
 	tests := []struct {
 		name string
 		args args
-		want []*image.Rectangle
+		want []image.Rectangle
 	}{
-		// TODO: Add test cases.
+		{
+			name: "data-01",
+			args: args{
+				bboxes: bboxes1,
+			},
+			want: []image.Rectangle{image.Rectangle{Min: image.Point{X: 1, Y: 2}, Max: image.Point{X: 3, Y: 4}}},
+		},
 	}
 	for _, tt := range tests {
 		t.Run(tt.name, func(t *testing.T) {
diff --git a/pkg/steering/test_data/bboxes-02.json b/pkg/steering/test_data/bboxes-02.json
index a4b6837..7c25790 100644
--- a/pkg/steering/test_data/bboxes-02.json
+++ b/pkg/steering/test_data/bboxes-02.json
@@ -8,10 +8,10 @@
       "confidence": 0.82714844
     },
     {
-      "right": 0.6894531,
-      "top": 0.111816406,
+      "right": 0.2794531,
+      "top": 0.301816406,
       "left": 0.15698242,
-      "bottom": 0.66748047,
+      "bottom": 0.65748047,
       "confidence": 0.83447266
     },
     {