cyrilix/goupnp
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix max range on Fixed14_4.SetParts.

Browse Source
This commit is contained in:
John Beisley
2021-09-05 15:17:50 +01:00
committed by Huin
parent e043d6666b
commit cc93611581
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
v2/soap/types/types.go
View File

@@ -266,6 +266,7 @@ func (v *R8) UnmarshalText(b []byte) error {
const Fixed14_4Denominator = 1e4 const Fixed14_4Denominator = 1e4
const Fixed14_4MaxInteger = 1e14 - 1 const Fixed14_4MaxInteger = 1e14 - 1
const Fixed14_4MaxFractional = 1e18 - 1 const Fixed14_4MaxFractional = 1e18 - 1
const Fixed14_4MaxFrac = Fixed14_4Denominator - 1
// Fixed14_4 represents a fixed point number with up to 14 decimal digits // Fixed14_4 represents a fixed point number with up to 14 decimal digits
// before the decimal point (integer part), and up to 4 decimal digits // before the decimal point (integer part), and up to 4 decimal digits
@@ -307,7 +308,7 @@ func (v *Fixed14_4) SetParts(intPart int64, fracPart int16) error {
if intPart < -Fixed14_4MaxInteger || intPart > Fixed14_4MaxInteger { if intPart < -Fixed14_4MaxInteger || intPart > Fixed14_4MaxInteger {
return fmt.Errorf("want intPart in range (-1e14,1e14), got %d", intPart) return fmt.Errorf("want intPart in range (-1e14,1e14), got %d", intPart)
} }
if fracPart < -Fixed14_4Denominator || fracPart > Fixed14_4Denominator { if fracPart < -Fixed14_4MaxFrac || fracPart > Fixed14_4MaxFrac {
return fmt.Errorf("want fracPart in range (-1e4,1e4), got %d", fracPart) return fmt.Errorf("want fracPart in range (-1e4,1e4), got %d", fracPart)
} }
v.Fractional = intPart*Fixed14_4Denominator + int64(fracPart) v.Fractional = intPart*Fixed14_4Denominator + int64(fracPart)